[GStreamer] Playback rate is not set when pipeline is not ready.

[Piotr Grad]

When pipeline is not in paused or playing state, setRate method just return instead of postphoning requested rate. Also HTMLMediaElement is not notified about changed rate when:
1. there is error,
2. player is not able to change playback rate.
Already working on patch. Will be proposed soon.

[Piotr Grad]

Created attachment 220727 [details]
Patch

[Piotr Grad]

Created attachment 220827 [details]
Patch

[Eric Carlson]

Comment on attachment 220827 [details]
Patch

This looks fine to me, but I know very little about GStreamer so I would prefer if someone who does (pnormand?) gives it an r+

[Philippe Normand]

Comment on attachment 220827 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220827&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:638
> +    if (m_changingRate) {

Can this be changed to an early return please?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1473
> +    if (getStateResult == GST_STATE_CHANGE_SUCCESS && (state == GST_STATE_PAUSED || state == GST_STATE_PLAYING)) {

the second test could be simplified to state >= GST_STATE_PAUSED

[Piotr Grad]

Created attachment 221024 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 221024 [details]
Patch

Clearing flags on attachment: 221024

Committed r161984: <http://trac.webkit.org/changeset/161984>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.