Bug 126691 - Remove extra includes from FTL
Summary: Remove extra includes from FTL
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 06:19 PST by Peter Molnar
Modified: 2014-12-05 05:23 PST (History)
2 users (show)

See Also:

Attachments
patch (12.82 KB, patch)
2014-01-09 06:19 PST, Peter Molnar 		no flags Details | Formatted Diff | Diff
patch (11.96 KB, patch)
2014-02-10 04:39 PST, Peter Molnar 		fpizlo: review-
fpizlo: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Molnar 2014-01-09 06:19:02 PST 
Remove extra includes from FTL
Comment 1 Peter Molnar 2014-01-09 06:19:56 PST 
Created attachment 220721 [details]
patch
Comment 2 Andreas Kling 2014-02-07 02:10:27 PST 
Comment on attachment 220721 [details]
patch

r=me if this still applies/builds.
Comment 3 Peter Molnar 2014-02-10 04:39:31 PST 
Created attachment 223696 [details]
patch
Comment 4 Peter Molnar 2014-02-10 04:39:56 PST 
(In reply to comment #2)
> (From update of attachment 220721 [details])
> r=me if this still applies/builds.

No, it doesn't apply, updated the patch.
Comment 5 Filip Pizlo 2014-02-10 08:09:08 PST 
(In reply to comment #2)
> (From update of attachment 220721 [details])
> r=me if this still applies/builds.

Note that EWS isn't building or testing FTL right now.
Comment 6 Filip Pizlo 2014-02-10 08:11:47 PST 
I don't like this patch at all. You're basically trying to come up with the minimal set of include statements that works, but that relies on a lot of inclusion. This means that if we cleaned up some of the headers to include fewer things, we'd need to add back the include statements that you removed. I don't like this at all; such changes are just pure noise and add nothing to the project.
Comment 7 Filip Pizlo 2014-02-10 08:12:13 PST 
Comment on attachment 223696 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=223696&action=review

> Source/JavaScriptCore/ftl/FTLAbbreviations.h:-33
> -#include "FTLAbbreviatedTypes.h"

This is very suspicious.
Comment 8 Csaba Osztrogonác 2014-02-13 04:12:24 PST 
Comment on attachment 220721 [details]
patch

Cleared Andreas Kling's review+ from obsolete attachment 220721 [details] so that this bug does not appear in http://webkit.org/pending-commit.