Bug 126676 - Web Inspector: Correctly track time bounds of WebInspector.Timeline and WebInspector.TimelineRecording
Summary: Web Inspector: Correctly track time bounds of WebInspector.Timeline and WebIn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-08 19:07 PST by Timothy Hatcher
Modified: 2014-01-20 19:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (11.23 KB, patch)
2014-01-08 19:11 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (3.32 KB, patch)
2014-01-10 15:01 PST, Timothy Hatcher 		timothy: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-08 19:07:40 PST 
The startTime and endTime were not correct when Network timeline needed to be taken into account (due to its dynamic loading nature.)
Comment 1 Radar WebKit Bug Importer 2014-01-08 19:08:24 PST 
<rdar://problem/15778935>
Comment 2 Timothy Hatcher 2014-01-08 19:11:56 PST 
Created attachment 220690 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-09 13:35:17 PST 
Comment on attachment 220690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220690&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:64
> +            }.bind(this));

You could use the thisObject optional param to Map.prototype.forEach. E.g.:

    forEach(function() {...}, this);

instead of

    forEach(function() {...}.bind(this));

> Source/WebInspectorUI/UserInterface/TimelineRecording.js:74
> +        }.bind(this));

Ditto
Comment 4 Timothy Hatcher 2014-01-10 15:01:43 PST 
Created attachment 220894 [details]
Patch
Comment 5 Timothy Hatcher 2014-01-20 19:00:55 PST 
https://trac.webkit.org/changeset/162402