Bug 126667 – Web Inspector: Update the current WebInspector.TimelineView when time range changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

When the TimelineOverview time selection changes, update the current TimelineView.

[Timothy Hatcher]

Created attachment 220671 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/15776691>

[Radar WebKit Bug Importer]

<rdar://problem/15776693>

[Joseph Pecoraro]

Comment on attachment 220671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220671&action=review

r=me

> Source/WebInspectorUI/UserInterface/TimelineContentView.js:196
> +        var endTime = Math.max(WebInspector.timelineManager.recording.endTime || startTime, startTime);

Hmm, this doesn't sound right. Maybe the "|| startTime" should just go away, no?

> Source/WebInspectorUI/UserInterface/TimelineOverview.js:167
> +        // Update all ruler element to the new required width.

Typo: "all ruler" => "ruler"

> Source/WebInspectorUI/UserInterface/TimelineView.js:169
> +        this._scheduledLayoutUpdateIdentifier = requestAnimationFrame(this.updateLayout.bind(this));

How often will we updateLayout? Maybe we should cache an updateLayout.bind(this) to prevent function creation churn?

[Timothy Hatcher]

Comment on attachment 220671 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220671&action=review

>> Source/WebInspectorUI/UserInterface/TimelineContentView.js:196
>> +        var endTime = Math.max(WebInspector.timelineManager.recording.endTime || startTime, startTime);
> 
> Hmm, this doesn't sound right. Maybe the "|| startTime" should just go away, no?

I meant to revet this line. At one point I had other doe in there for the Math.max. Now WebInspector.timelineManager.recording.endTime is always what I want.

>> Source/WebInspectorUI/UserInterface/TimelineView.js:169
>> +        this._scheduledLayoutUpdateIdentifier = requestAnimationFrame(this.updateLayout.bind(this));
> 
> How often will we updateLayout? Maybe we should cache an updateLayout.bind(this) to prevent function creation churn?

Good idea. I'll do that in a follow up with all the places this happens.

[Timothy Hatcher]

https://trac.webkit.org/changeset/162411