Bug 126661 - Clean up confusing names and calculations in image-dragging functions
Summary: Clean up confusing names and calculations in image-dragging functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks: 125375
  Show dependency tree / graph
 
Reported: 2014-01-08 13:31 PST by BJ Burg
Modified: 2014-01-08 18:17 PST (History)
1 user (show)

See Also:

Attachments
patch (6.65 KB, patch)
2014-01-08 13:41 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-01-08 13:31:27 PST 
Several functions used to implement image dragging have unhelpful variable names and scale-related calculations that could be simpler. This led to mistakes where the wrong scale was applied.
Comment 1 BJ Burg 2014-01-08 13:41:23 PST 
Created attachment 220661 [details]
patch
Comment 2 WebKit Commit Bot 2014-01-08 18:17:51 PST 
Comment on attachment 220661 [details]
patch

Clearing flags on attachment: 220661

Committed r161537: <http://trac.webkit.org/changeset/161537>
Comment 3 WebKit Commit Bot 2014-01-08 18:17:53 PST 
All reviewed patches have been landed.  Closing bug.