Bug 126656 - Subpixel layout: RenderSearchField and RenderTextControlSingleLine() needs bias centering.
Summary: Subpixel layout: RenderSearchField and RenderTextControlSingleLine() needs bi...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 126283
  Show dependency tree / graph
 
Reported: 2014-01-08 12:47 PST by zalan
Modified: 2014-01-14 16:15 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-08 12:47:02 PST 
This is similar to bug 125659 with even more bias centering. (probably should merge them)

innerTextRenderer->setLogicalTop(innerTextRenderer->logicalTop() - (logicalHeightDiff / 2 + layoutMod(logicalHeightDiff, 2)));

failed cases:
fast/block/float/032.html
fast/forms/search-vertical-alignment.html
fast/ruby/ruby-svg-crash.html
Comment 1 Simon Fraser (smfr) 2014-01-08 15:26:53 PST 
Check FF, prefer subpixel.
Comment 2 Radar WebKit Bug Importer 2014-01-14 10:24:01 PST 
<rdar://problem/15815537>
Comment 3 zalan 2014-01-14 16:15:21 PST 
FF renders search widgets differently (search-vertical-alignment.html). The other 2 failed cases are not related and most likely result of some flakiness. 
Prefer new behavior.