Bug 126653 - Subpixel layout: RenderMultiColumnBlock::computeColumnCountAndWidth() needs flooring.
Summary: Subpixel layout: RenderMultiColumnBlock::computeColumnCountAndWidth() needs f...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 126283
  Show dependency treegraph
 
Reported: 2014-01-08 11:59 PST by zalan
Modified: 2014-01-15 13:09 PST (History)
3 users (show)

See Also:


Attachments
rendering snapshots (93.00 KB, image/jpeg)
2014-01-15 13:07 PST, zalan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-08 11:59:43 PST
This is rather similar to bug 126646. We produce an off by one pixel rendering when subpixel is on, though flooring it to CSS pixel would defeat the purpose of subpixel positioning the column content.

m_columnWidth = std::max<LayoutUnit>(0, (availWidth - ((m_columnCount - 1) * colGap)) / m_columnCount);

failed cases:
fast/multicol/newmulticol/column-rules-fixed-height.html
fast/multicol/newmulticol/columns-shorthand-parsing.html
fast/multicol/newmulticol/layers-in-multicol.html
Comment 1 Simon Fraser (smfr) 2014-01-08 15:26:08 PST
Talk to Hyatt.
Comment 2 zalan 2014-01-15 13:07:43 PST
Created attachment 221301 [details]
rendering snapshots
Comment 3 Radar WebKit Bug Importer 2014-01-15 13:08:31 PST
<rdar://problem/15827900>
Comment 4 zalan 2014-01-15 13:09:25 PST
FF(v26) rendering is in-between subpixel off and subpixel on. Prefer current subpixel rendering.