Bug 126651 - Subpixel layout: RenderFlexibleBox::alignChildren() needs biased centering.
Summary: Subpixel layout: RenderFlexibleBox::alignChildren() needs biased centering.
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 126283
  Show dependency tree / graph
 
Reported: 2014-01-08 11:49 PST by zalan
Modified: 2014-01-14 16:27 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-08 11:49:16 PST 
While adjusting the alignment for children (adjustAlignmentForChild()), we should bias offset the delta when center positioning.
adjustAlignmentForChild(*child, availableAlignmentSpaceForChild(lineCrossAxisExtent, *child) / 2);

failed cases:
fast/forms/range/input-appearance-range.html
fast/hidpi/video-controls-in-hidpi.html
fast/layers/video-layer.html
fast/multicol/client-rects.html
Comment 1 Simon Fraser (smfr) 2014-01-08 15:25:44 PST 
Check FF behavior, but prefer subpixel positioning.
Comment 2 Radar WebKit Bug Importer 2014-01-14 10:22:35 PST 
<rdar://problem/15815513>
Comment 3 zalan 2014-01-14 16:27:04 PST 
These custom controls look different on FF. By looking at the vertical positioning, the old behavior looks more centered. This is similar to bug 101848 (widget content centering)