Bug 126647 - Subpixel layout: adjustFloatForSubPixelLayout() needs flooring.
Summary: Subpixel layout: adjustFloatForSubPixelLayout() needs flooring.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks: 126283
  Show dependency tree / graph
 
Reported: 2014-01-08 11:12 PST by zalan
Modified: 2014-01-14 16:32 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-01-08 11:12:20 PST 
Margins calculation/accumulation can lead to different CSS pixel result when subpixel is on.

summary::-webkit-details-marker {
    margin-right: 1em;
}

failed test case:
fast/html/details-position.html


We should just rebaseline it as flooring to int here would defeat the purpose of subpixels.
Comment 1 Simon Fraser (smfr) 2014-01-08 15:22:52 PST 
Rebaselining sounds fine.
Comment 2 Jon Lee 2014-01-14 10:19:41 PST 
Can we mark this as complete?