Bug 126637 - [GTK][WK2] unskip passing unit tests
Summary: [GTK][WK2] unskip passing unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Holt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-08 06:30 PST by Brian Holt
Modified: 2014-01-08 07:19 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.02 KB, patch)
2014-01-08 06:44 PST, Brian Holt 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Holt 2014-01-08 06:30:12 PST 
$Tools/Scripts/run-gtk-tests --no-xvfb --skipped=ignore

Tests failed (2): /WebKit2Gtk/TestInspectorServer, /WebKit2/TestWebKit2
Tests that timed out (1): /WebKit2Gtk/TestWebKitPolicyClient

$Tools/Scripts/run-gtk-tests  --skipped=ignore

Tests failed (4): /WebKit2Gtk/TestWebKitWebView, /WebKit2Gtk/TestWebKitAccessibility, /WebKit2Gtk/TestInspectorServer, /WebKit2/TestWebKit2
Tests that timed out (3): /WebKit2Gtk/TestWebKitPolicyClient, /WebKit2Gtk/TestUIClient, /WebKit2Gtk/TestContextMenu

TestResources and TestAuthentication are currently skipped but both pass under xvfb and X.
Comment 1 Brian Holt 2014-01-08 06:44:39 PST 
Created attachment 220627 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-01-08 06:46:58 PST 
Comment on attachment 220627 [details]
Patch

Ok, let's try to unskip them and watch the bots for a while. Thanks.
Comment 3 WebKit Commit Bot 2014-01-08 07:19:43 PST 
Comment on attachment 220627 [details]
Patch

Clearing flags on attachment: 220627

Committed r161499: <http://trac.webkit.org/changeset/161499>
Comment 4 WebKit Commit Bot 2014-01-08 07:19:44 PST 
All reviewed patches have been landed.  Closing bug.