Bug 126629 - invalid preprocessing directive in mathtags.in
Summary: invalid preprocessing directive in mathtags.in
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on: 100626
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-08 01:43 PST by Frédéric Wang (:fredw)
Modified: 2014-01-08 06:18 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2014-01-08 02:38 PST, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2014-01-08 01:43:14 PST 
WebCore/Modules/mediacontrols/mediaControlsApple.js:825:34: warning: empty character constant [-Winvalid-pp-token]
1 warning generated.
WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive
# These presentation MathML elements are not implemented.
  ^
1 error generated.
WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive
# These presentation MathML elements are not implemented.

In mathtags.in, # should be replaced with // for comments.
Comment 1 Frédéric Wang (:fredw) 2014-01-08 02:38:57 PST 
Created attachment 220618 [details]
Patch

// does not seem to be accepted outside a # preprocessing instruction, so let's drop these comments.
Comment 2 WebKit Commit Bot 2014-01-08 06:18:12 PST 
Comment on attachment 220618 [details]
Patch

Clearing flags on attachment: 220618

Committed r161495: <http://trac.webkit.org/changeset/161495>
Comment 3 WebKit Commit Bot 2014-01-08 06:18:14 PST 
All reviewed patches have been landed.  Closing bug.