Bug 126609 - [EFL][WK2] Fix failing ewk_view_page_contents_get() API test
Summary: [EFL][WK2] Fix failing ewk_view_page_contents_get() API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 17:28 PST by Jinwoo Song
Modified: 2014-01-07 18:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2014-01-07 17:34 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
patch for landing (3.63 KB, patch)
2014-01-07 18:03 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-07 17:28:50 PST 
ewk_view_page_contents_get() API test is failing because of wrong expected result.
Comment 1 Jinwoo Song 2014-01-07 17:34:11 PST 
Created attachment 220573 [details]
Patch
Comment 2 Gyuyoung Kim 2014-01-07 17:50:07 PST 
Comment on attachment 220573 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220573&action=review

LGTM except for some minor comments.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:217
> +        // Layout tests, so checking the amount of bytes is enough.

Layout -> layout

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:218
> +        Eina_File* pFile = eina_file_open(TEST_RESOURCES_DIR "/resultMHTML.mht", false);

It looks pFile is not EFL or WebKit variable naming style. How about using 'f' or 'file' for it ?
Comment 3 Jinwoo Song 2014-01-07 18:03:20 PST 
Created attachment 220577 [details]
patch for landing
Comment 4 Jinwoo Song 2014-01-07 18:03:43 PST 
Comment on attachment 220573 [details]
Patch

done.
Comment 5 WebKit Commit Bot 2014-01-07 18:38:03 PST 
Comment on attachment 220577 [details]
patch for landing

Clearing flags on attachment: 220577

Committed r161478: <http://trac.webkit.org/changeset/161478>
Comment 6 WebKit Commit Bot 2014-01-07 18:38:06 PST 
All reviewed patches have been landed.  Closing bug.