Bug 126602 - Move expected results out of messages_unittest.py into separate files
Summary: Move expected results out of messages_unittest.py into separate files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 14:39 PST by Simon Fraser (smfr)
Modified: 2014-01-07 17:00 PST (History)
4 users (show)

See Also:


Attachments
Patch (58.85 KB, patch)
2014-01-07 14:40 PST, Simon Fraser (smfr)
andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-01-07 14:39:51 PST
Move expected results out of messages_unittest.py into separate files
Comment 1 Simon Fraser (smfr) 2014-01-07 14:40:51 PST
Created attachment 220551 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-07 14:41:51 PST
Attachment 220551 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp', u'Source/WebKit2/Scripts/webkit2/Messages-expected.h', u'Source/WebKit2/Scripts/webkit2/messages_unittest.py', u'Source/WebKit2/Scripts/webkit2/test-messages.in', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:25:  #ifndef header guard has wrong style, please use: Messages_expected_h  [build/header_guard] [5]
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:26:  WebPageMessages_h is incorrect. #defined constants should use all uppercase names with words separated by underscores.  [readability/naming/define/constants] [4]
ERROR: Source/WebKit2/Scripts/webkit2/Messages-expected.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Scripts/webkit2/MessageReceiver-expected.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2014-01-07 14:55:06 PST
Comment on attachment 220551 [details]
Patch

Attachment 220551 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5667057144168448
Comment 4 Build Bot 2014-01-07 15:13:54 PST
Comment on attachment 220551 [details]
Patch

Attachment 220551 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4946550610460672
Comment 5 Simon Fraser (smfr) 2014-01-07 17:00:07 PST
https://trac.webkit.org/r161472