Bug 126582 - [GTK][CMake] Links system library to gtkdoc-scan instead of the built one
Summary: [GTK][CMake] Links system library to gtkdoc-scan instead of the built one
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 07:27 PST by Gustavo Noronha (kov)
Modified: 2014-01-09 06:07 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2014-01-07 07:28 PST, Gustavo Noronha (kov) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2014-01-07 07:27:27 PST 
[GTK][CMake] Links system library to gtkdoc-scan instead of the built one
Comment 1 Gustavo Noronha (kov) 2014-01-07 07:28:54 PST 
Created attachment 220524 [details]
Patch
Comment 2 Martin Robinson 2014-01-07 08:25:12 PST 
Comment on attachment 220524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220524&action=review

> Tools/gtk/common.py:48
> +            library_build_dir = build_path(*args)

What's going on here that it needs the root of the build directory instead of the directory with the libraries?
Comment 3 Gustavo Noronha (kov) 2014-01-08 04:14:54 PST 
(In reply to comment #2)
> > Tools/gtk/common.py:48
> > +            library_build_dir = build_path(*args)
> 
> What's going on here that it needs the root of the build directory instead of the directory with the libraries?

Exactly! We could land your patch to put the binaries in bin/ and libs in lib/ instead if you prefer, I don't know why they started going to the root, so it may be better to be explicit about it, r=me on it.
Comment 4 Martin Robinson 2014-01-08 17:16:12 PST 
Thanks. Landed this in: http://trac.webkit.org/changeset/161528.
Comment 5 Gustavo Noronha (kov) 2014-01-09 06:07:21 PST 
Comment on attachment 220524 [details]
Patch

Thanks!