Bug 126564 - Missleading style error when mixing system and non-system header include lines.
Summary: Missleading style error when mixing system and non-system header include lines.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-07 00:08 PST by Gergő Balogh
Modified: 2014-01-08 18:09 PST (History)
6 users (show)

See Also:


Attachments
patch (4.99 KB, patch)
2014-01-07 00:14 PST, Gergő Balogh
no flags Details | Formatted Diff | Diff
patch fix (4.67 KB, patch)
2014-01-07 23:59 PST, Gergő Balogh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gergő Balogh 2014-01-07 00:08:34 PST
example:

#include "ArgumentEncoder.h" 
#include "ProcessLauncher.h" 
#include <QApplication>
#include <QLocalServer>
#include <QLocalSocket>
#include "WebPageProxyMessageKinds.h" 
#include "WorkItem.h"

ERROR: bad.cpp:5: Alphabetical sorting problem. [build/include_order] [4]
Comment 1 Gergő Balogh 2014-01-07 00:14:28 PST
Created attachment 220497 [details]
patch
Comment 2 Ryosuke Niwa 2014-01-07 02:17:53 PST
Comment on attachment 220497 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220497&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:2922
> +                if previous_line.strip() > line.strip():

We should probably put else here so that we don't end up spitting out two error messages.
Comment 3 Gergő Balogh 2014-01-07 23:59:42 PST
Created attachment 220601 [details]
patch fix
Comment 4 WebKit Commit Bot 2014-01-08 18:09:20 PST
Comment on attachment 220601 [details]
patch fix

Clearing flags on attachment: 220601

Committed r161535: <http://trac.webkit.org/changeset/161535>
Comment 5 WebKit Commit Bot 2014-01-08 18:09:23 PST
All reviewed patches have been landed.  Closing bug.