Bug 126559 - [Mac] Be more correct in dealing with NSControlSize
Summary: [Mac] Be more correct in dealing with NSControlSize
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Depends on:
Reported: 2014-01-06 18:44 PST by Mark Rowe (bdash)
Modified: 2014-01-06 20:42 PST (History)
4 users (show)

See Also:

Patch (4.37 KB, patch)
2014-01-06 18:46 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2014-01-06 20:06 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-01-06 18:44:02 PST
In several places in WebCore we pass ints or ScrollbarControlSizes in places that NSControlSize is expected. This will break if NSControlSize ever moves from a typedef for NSInteger to an enum.
Comment 1 Mark Rowe (bdash) 2014-01-06 18:46:58 PST
Created attachment 220481 [details]
Comment 2 Ryosuke Niwa 2014-01-06 19:34:35 PST
Comment on attachment 220481 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=220481&action=review

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:167
> +}

We should have a default value just in case?
Comment 3 Mark Rowe (bdash) 2014-01-06 20:06:32 PST
Created attachment 220485 [details]
Comment 4 WebKit Commit Bot 2014-01-06 20:42:02 PST
Comment on attachment 220485 [details]

Clearing flags on attachment: 220485

Committed r161397: <http://trac.webkit.org/changeset/161397>
Comment 5 WebKit Commit Bot 2014-01-06 20:42:04 PST
All reviewed patches have been landed.  Closing bug.