RESOLVED FIXED126559
[Mac] Be more correct in dealing with NSControlSize 
https://bugs.webkit.org/show_bug.cgi?id=126559
Summary [Mac] Be more correct in dealing with NSControlSize
Mark Rowe (bdash)
Reported 2014-01-06 18:44:02 PST
In several places in WebCore we pass ints or ScrollbarControlSizes in places that NSControlSize is expected. This will break if NSControlSize ever moves from a typedef for NSInteger to an enum.
Attachments
Patch (4.37 KB, patch)
2014-01-06 18:46 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Patch (4.43 KB, patch)
2014-01-06 20:06 PST, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2014-01-06 18:46:58 PST
Created attachment 220481 [details] Patch
Ryosuke Niwa
Comment 2 2014-01-06 19:34:35 PST
Comment on attachment 220481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220481&action=review > Source/WebCore/platform/mac/ScrollbarThemeMac.mm:167 > +} We should have a default value just in case?
Mark Rowe (bdash)
Comment 3 2014-01-06 20:06:32 PST
Created attachment 220485 [details] Patch
WebKit Commit Bot
Comment 4 2014-01-06 20:42:02 PST
Comment on attachment 220485 [details] Patch Clearing flags on attachment: 220485 Committed r161397: <http://trac.webkit.org/changeset/161397>
WebKit Commit Bot
Comment 5 2014-01-06 20:42:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.