RESOLVED FIXED 126556
Heap::collect shouldn't be responsible for sweeping 
https://bugs.webkit.org/show_bug.cgi?id=126556
Summary Heap::collect shouldn't be responsible for sweeping
Mark Hahnenberg
Reported 2014-01-06 17:30:32 PST
Sweeping happens at an awkward time during collection due to the fact that destructors can cause arbitrary reentry into the VM. If we were to delay sweeping until after collection was completely finished then we would no longer have this problem.
Attachments
Patch (4.36 KB, patch)
2014-01-06 20:53 PST, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-01-06 20:53:57 PST
Created attachment 220488 [details] Patch
Geoffrey Garen
Comment 2 2014-01-06 21:32:00 PST
Comment on attachment 220488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220488&action=review r=me > Source/JavaScriptCore/heap/Heap.cpp:734 > + SamplingRegion samplingRegion("Garbage Collection: Sweeping"); Sampling region should probably go before DelayedReleaseScope, so we sample all destructor time, including delayed destructor time.
Mark Hahnenberg
Comment 3 2014-01-07 09:36:02 PST
Committed r161429: <http://trac.webkit.org/changeset/161429>
Note You need to log in before you can comment on or make changes to this bug.