Bug 126550 - CStack Branch: Disable JIT stack alignment check for ARM64
Summary: CStack Branch: Disable JIT stack alignment check for ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 17:01 PST by Michael Saboff
Modified: 2014-01-06 17:53 PST (History)
0 users

See Also:


Attachments
Patch (1.25 KB, patch)
2014-01-06 17:20 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-01-06 17:01:08 PST
Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment() is not needed.  Also, the implementation of checkStackPointerAlignment() would need to be reworked given the limits on the operations that can be done with the stack pointer register in ARM64.  Therefore checkStackPointerAlignment() should be conditionally disabled for ARM64.
Comment 1 Michael Saboff 2014-01-06 17:20:57 PST
Created attachment 220474 [details]
Patch
Comment 2 Mark Lam 2014-01-06 17:39:06 PST
Comment on attachment 220474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220474&action=review

r=me with comment fix.

> Source/JavaScriptCore/ChangeLog:8
> +        Disabled the compilation of the body of checkStackPointerAlignment for ARM64.

Can you put your bug comment here instead?  The bug comment said, "Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment() is not needed.  Also, the implementation of checkStackPointerAlignment() would need to be reworked given the limits on the operations that can be done with the stack pointer register in ARM64.  Therefore checkStackPointerAlignment() should be conditionally disabled for ARM64."  I think your bug comment does a good job of explaining why we needed this change.
Comment 3 Michael Saboff 2014-01-06 17:53:41 PST
Committed r161390: <http://trac.webkit.org/changeset/161390>