Bug 126539 - CStack: JSLock drop and grab lock APIs should be private.
Summary: CStack: JSLock drop and grab lock APIs should be private.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 14:08 PST by Mark Lam
Modified: 2014-01-06 14:15 PST (History)
5 users (show)

See Also:


Attachments
the patch. (1.66 KB, patch)
2014-01-06 14:12 PST, Mark Lam
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-01-06 14:08:31 PST
We want the dropping and re-acquisition of the VM API lock to be via the DropAllLocks raii object.  Hence, we should not publicly publishing the APIs for dropping and re-acquiring the locks.
Comment 1 Mark Lam 2014-01-06 14:12:01 PST
Created attachment 220456 [details]
the patch.
Comment 2 Mark Hahnenberg 2014-01-06 14:12:28 PST
Comment on attachment 220456 [details]
the patch.

r=me
Comment 3 Mark Lam 2014-01-06 14:15:06 PST
Thanks for the review.  Landed in r161372 on the jsCStack branch: <http://trac.webkit.org/r161372>.