Bug 126532 – Add new files for UI-side scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Add new files for UI-side scrolling

[Simon Fraser (smfr)]

Created attachment 220445 [details]
Patch

[Anders Carlsson]

Comment on attachment 220445 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220445&action=review

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:49
> +    explicit RemoteScrollingCoordinatorProxy(WebPageProxy*);

Reference?

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:41
> +

Please get rid of this newline.

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:46
> +    virtual bool isRemoteScrollingTree() const OVERRIDE { return true; }
> +
> +    virtual EventResult tryToHandleWheelEvent(const WebCore::PlatformWheelEvent&) OVERRIDE;

I'd get rid of this newline.

> Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.h:68
> +    // CoreIPC::MessageReceiver

Should just be IPC::.

> Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in:24
> +    ScrollPositionChangedForNode(uint64_t nodeID, WebCore::FloatPoint scrollPosition);

Maybe DidChange instead of Changed?

[Build Bot]

Comment on attachment 220445 [details]
Patch

Attachment 220445 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5462873593610240

[Build Bot]

Comment on attachment 220445 [details]
Patch

Attachment 220445 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5147659232870400

[Simon Fraser (smfr)]

https://trac.webkit.org/r161373