Bug 126531 - On iOS, zooming in with a TileController-backed main frame makes hundreds of tiles
Summary: On iOS, zooming in with a TileController-backed main frame makes hundreds of ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on: 126536
  Show dependency treegraph
Reported: 2014-01-06 11:40 PST by Tim Horton
Modified: 2014-01-16 23:27 PST (History)
4 users (show)

See Also:

patch (7.68 KB, patch)
2014-01-15 13:41 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-06 11:40:43 PST

The exposed rect that's handed through to TileController is in view coordinates. If we delegate page scale to the view (like iOS), this causes trouble, and we need to transform it appropriately.
Comment 1 Tim Horton 2014-01-15 13:33:34 PST
Not quite right.

TileController's exposedRect is in FrameView coordinate space, but the TileController's visibleRect is in 'document' space. We need to scale the exposedRect. This also makes exposedRect stuff work correctly on desktop if you flip it on for Safari/MiniBrowser and zoom.

Also, WKContentView was not sending the exposedRect in FrameView coordinate space, but it should be.
Comment 2 Tim Horton 2014-01-15 13:41:26 PST
Created attachment 221305 [details]
Comment 3 WebKit Commit Bot 2014-01-16 23:27:17 PST
Comment on attachment 221305 [details]

Clearing flags on attachment: 221305

Committed r162189: <http://trac.webkit.org/changeset/162189>
Comment 4 WebKit Commit Bot 2014-01-16 23:27:19 PST
All reviewed patches have been landed.  Closing bug.