Bug 126528 - [CSS Shapes] shape-outside layout incorrect when line spans rounded box rounded corners
Summary: [CSS Shapes] shape-outside layout incorrect when line spans rounded box round...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 10:11 PST by Hans Muller
Modified: 2014-01-07 10:26 PST (History)
5 users (show)

See Also:

Attachments
Test case. (972 bytes, text/html)
2014-01-06 10:11 PST, Hans Muller 		no flags Details
Test case screenshot. (7.15 KB, image/png)
2014-01-06 10:16 PST, Hans Muller 		no flags Details
Patch (4.17 KB, patch)
2014-01-06 12:05 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2014-01-06 16:17 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Muller 2014-01-06 10:11:26 PST 
Created attachment 220439 [details]
Test case.

If a line spans a shape-outside box's top/bottom rounded corners, it's starting point is based on (only) the intersection of the top/bottom edges of the line and the corner arcs.

The attached example demonstrates the problem.
Comment 1 Hans Muller 2014-01-06 10:16:35 PST 
Created attachment 220440 [details]
Test case screenshot.
Comment 2 Hans Muller 2014-01-06 12:05:43 PST 
Created attachment 220444 [details]
Patch

BoxShape::getExcludedIntervals() now checks for the special case where the line spans the top and bottom rounded corners - which implies that the excluded interval is the box's horizontal extent.
Comment 3 Hans Muller 2014-01-06 16:17:04 PST 
Created attachment 220467 [details]
Patch

Corrected the test filenames.
Comment 4 Andreas Kling 2014-01-07 08:03:45 PST 
Comment on attachment 220467 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2014-01-07 10:26:31 PST 
Comment on attachment 220467 [details]
Patch

Clearing flags on attachment: 220467

Committed r161434: <http://trac.webkit.org/changeset/161434>
Comment 6 WebKit Commit Bot 2014-01-07 10:26:32 PST 
All reviewed patches have been landed.  Closing bug.