Bug 126515 - The attribute 'size' of 'select' element doesn't work when size=2 or 3.
Summary: The attribute 'size' of 'select' element doesn't work when size=2 or 3.
Status: RESOLVED DUPLICATE of bug 28900
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-06 01:29 PST by ChangSeok Oh
Modified: 2014-01-06 22:22 PST (History)
2 users (show)

See Also:


Attachments
Testcase. (391 bytes, text/html)
2014-01-06 01:30 PST, ChangSeok Oh
no flags Details
Patch (1.65 KB, patch)
2014-01-06 01:43 PST, ChangSeok Oh
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (857.89 KB, application/zip)
2014-01-06 02:43 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (885.87 KB, application/zip)
2014-01-06 02:58 PST, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (1.15 MB, application/zip)
2014-01-06 03:38 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2014-01-06 01:29:09 PST
When the size attribute of select tag has 2 or 3. it's working properly. it works like 'size=4'.
Firefox is working with little regard to size=2/3.
As my investigation, this is because minSize in RenderListBox.cpp is limited to 4. 
I can guess there has been a historical reason there with the following comment. but I doubt if it's still valid now.
> // The minSize constant was originally defined to render scrollbars correctly
> // This might vary for different platforms.

I couldn't find any problem for Macport running on Marvericks and Lion. The scrollbar shows up and automatically hide after few seconds on the platforms.
And also I don't think GTK port has any problem for size=2/3, though GTK+ 3.0 doesn't paint scrollbar for such a short list, but it presents more lists remained by using up/down arrow indicators.

I propose to change minSize from 4 to 2.
Comment 1 ChangSeok Oh 2014-01-06 01:30:08 PST
Created attachment 220420 [details]
Testcase.
Comment 2 ChangSeok Oh 2014-01-06 01:43:59 PST
Created attachment 220422 [details]
Patch
Comment 3 Build Bot 2014-01-06 02:43:28 PST
Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5269876822245376

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html
Comment 4 Build Bot 2014-01-06 02:43:29 PST
Created attachment 220426 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-01-06 02:58:48 PST
Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6509237953888256

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html
Comment 6 Build Bot 2014-01-06 02:58:50 PST
Created attachment 220428 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-01-06 03:38:05 PST
Comment on attachment 220422 [details]
Patch

Attachment 220422 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5887309777993728

New failing tests:
fast/forms/disabled-select-change-index.html
fast/forms/listbox-bidi-align.html
fast/text/international/bidi-listbox-atsui.html
fast/forms/select-clientheight-with-multiple-attr.html
fast/text/international/bidi-listbox.html
fast/replaced/replaced-breaking.html
fast/events/select-element.html
Comment 8 Build Bot 2014-01-06 03:38:07 PST
Created attachment 220429 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Alexey Proskuryakov 2014-01-06 09:40:50 PST

*** This bug has been marked as a duplicate of bug 28900 ***
Comment 10 Alexey Proskuryakov 2014-01-06 09:41:49 PST
Comment on attachment 220422 [details]
Patch

Clearing review flag, please use the original bug.
Comment 11 ChangSeok Oh 2014-01-06 22:22:14 PST
(In reply to comment #10)
> (From update of attachment 220422 [details])
> Clearing review flag, please use the original bug.

Yeap