WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
126513
RenderBlock::clone() should return RenderPtr.
https://bugs.webkit.org/show_bug.cgi?id=126513
Summary
RenderBlock::clone() should return RenderPtr.
Andreas Kling
Reported
2014-01-06 00:36:12 PST
RenderBlock::clone() should return RenderPtr.
Attachments
Patch
(5.91 KB, patch)
2014-01-06 00:40 PST
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-01-06 00:40:31 PST
Created
attachment 220417
[details]
Patch
Antti Koivisto
Comment 2
2014-01-06 01:13:33 PST
Comment on
attachment 220417
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=220417&action=review
> Source/WebCore/rendering/RenderBlock.cpp:515 > + RenderPtr<RenderElement> cloneRenderer = element()->createElementRenderer(style()); > + cloneBlock = RenderPtr<RenderBlock>(toRenderBlock(cloneRenderer.leakPtr()));
:(
Andreas Kling
Comment 3
2014-01-06 02:35:57 PST
Committed
r161337
: <
http://trac.webkit.org/changeset/161337
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug