Bug 126509 – [EFL] Fix failing WebKit1 API test of ewk_view_setting_tiled_backing_store

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

[ RUN      ] EWKTestBase.ewk_view_setting_tiled_backing_store
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/WebKit/efl/tests/test_ewk_view.cpp:80: Failure
Value of: ewk_view_setting_tiled_backing_store_enabled_get(webView())
  Actual: true
Expected: false
[  FAILED  ] EWKTestBase.ewk_view_setting_tiled_backing_store (35 ms)

In WebKit1 EFL port, DRT is using tiled backing store webview so the setting value is set to true.

[Jinwoo Song]

Created attachment 220412 [details]
Patch

[Ryuan Choi]

Comment on attachment 220412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220412&action=review

> Source/WebKit/efl/ChangeLog:8
> +        In WebKit1 EFL port, DRT is using a webview based on tiled backing store,

If I am right, DRT is using single backing store.
I didn't know that test f/w uses tiled backing store as a default.

What do you think about changing default as single?

[Jinwoo Song]

Comment on attachment 220412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220412&action=review

>> Source/WebKit/efl/ChangeLog:8
>> +        In WebKit1 EFL port, DRT is using a webview based on tiled backing store,
> 
> If I am right, DRT is using single backing store.
> I didn't know that test f/w uses tiled backing store as a default.
> 
> What do you think about changing default as single?

As we discussed in irc, it would be better to use single backing store in unit test as your suggestion.

[Jinwoo Song]

Created attachment 220413 [details]
Patch

[Ryuan Choi]

(In reply to comment #4)
> Created an attachment (id=220413) [details]
> Patch

Thanks, LGTM.

[Gyuyoung Kim]

Comment on attachment 220413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220413&action=review

> Source/WebKit/efl/tests/test_ewk_view.cpp:75
> +* @brief Checking whether function properly get/set tiled backing store setting value.

It would be nicer if you mention this fixing in ChangeLog as well.

[Jinwoo Song]

Created attachment 220415 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 220415 [details]
Patch

Clearing flags on attachment: 220415

Committed r161331: <http://trac.webkit.org/changeset/161331>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.