Bug 126509 - [EFL] Fix failing WebKit1 API test of ewk_view_setting_tiled_backing_store
Summary: [EFL] Fix failing WebKit1 API test of ewk_view_setting_tiled_backing_store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-05 20:29 PST by Jinwoo Song
Modified: 2014-01-05 23:50 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2014-01-05 20:33 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (3.49 KB, patch)
2014-01-05 21:50 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (3.52 KB, patch)
2014-01-05 23:14 PST, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-05 20:29:43 PST 
[ RUN      ] EWKTestBase.ewk_view_setting_tiled_backing_store
/mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/WebKit/efl/tests/test_ewk_view.cpp:80: Failure
Value of: ewk_view_setting_tiled_backing_store_enabled_get(webView())
  Actual: true
Expected: false
[  FAILED  ] EWKTestBase.ewk_view_setting_tiled_backing_store (35 ms)

In WebKit1 EFL port, DRT is using tiled backing store webview so the setting value is set to true.
Comment 1 Jinwoo Song 2014-01-05 20:33:54 PST 
Created attachment 220412 [details]
Patch
Comment 2 Ryuan Choi 2014-01-05 20:41:27 PST 
Comment on attachment 220412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220412&action=review

> Source/WebKit/efl/ChangeLog:8
> +        In WebKit1 EFL port, DRT is using a webview based on tiled backing store,

If I am right, DRT is using single backing store.
I didn't know that test f/w uses tiled backing store as a default.

What do you think about changing default as single?
Comment 3 Jinwoo Song 2014-01-05 21:49:35 PST 
Comment on attachment 220412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220412&action=review

>> Source/WebKit/efl/ChangeLog:8
>> +        In WebKit1 EFL port, DRT is using a webview based on tiled backing store,
> 
> If I am right, DRT is using single backing store.
> I didn't know that test f/w uses tiled backing store as a default.
> 
> What do you think about changing default as single?

As we discussed in irc, it would be better to use single backing store in unit test as your suggestion.
Comment 4 Jinwoo Song 2014-01-05 21:50:31 PST 
Created attachment 220413 [details]
Patch
Comment 5 Ryuan Choi 2014-01-05 22:08:25 PST 
(In reply to comment #4)
> Created an attachment (id=220413) [details]
> Patch

Thanks, LGTM.
Comment 6 Gyuyoung Kim 2014-01-05 22:10:02 PST 
Comment on attachment 220413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220413&action=review

> Source/WebKit/efl/tests/test_ewk_view.cpp:75
> +* @brief Checking whether function properly get/set tiled backing store setting value.

It would be nicer if you mention this fixing in ChangeLog as well.
Comment 7 Jinwoo Song 2014-01-05 23:14:56 PST 
Created attachment 220415 [details]
Patch
Comment 8 WebKit Commit Bot 2014-01-05 23:50:09 PST 
Comment on attachment 220415 [details]
Patch

Clearing flags on attachment: 220415

Committed r161331: <http://trac.webkit.org/changeset/161331>
Comment 9 WebKit Commit Bot 2014-01-05 23:50:12 PST 
All reviewed patches have been landed.  Closing bug.