Bug 126500 - [Mac] Move Objective-C DOM bindings off the legacy WebKit availability macros
Summary: [Mac] Move Objective-C DOM bindings off the legacy WebKit availability macros
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on: 126499
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-05 02:06 PST by Mark Rowe (bdash)
Modified: 2014-01-06 22:05 PST (History)
11 users (show)

See Also:

Attachments
Patch (148.21 KB, patch)
2014-01-05 02:15 PST, Mark Rowe (bdash) 		sam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-01-05 02:06:34 PST 
The legacy WebKit availability macros are verbose, confusing, and provide no benefit over using the system availability macros directly. The original vision was that they'd serve a cross-platform purpose but that never came to be.
Comment 1 Mark Rowe (bdash) 2014-01-05 02:15:05 PST 
Created attachment 220394 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-05 02:16:43 PST 
Please wait for approval from timothy@apple.com (or another member of the Apple Safari Team) before submitting because this patch contains changes to the Apple Mac WebKit.framework public API.
Comment 3 Build Bot 2014-01-05 02:48:45 PST 
Comment on attachment 220394 [details]
Patch

Attachment 220394 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6217105015832576
Comment 4 Build Bot 2014-01-05 03:02:43 PST 
Comment on attachment 220394 [details]
Patch

Attachment 220394 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6543253960654848
Comment 5 Sam Weinig 2014-01-06 19:31:34 PST 
Comment on attachment 220394 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2014-01-06 20:52:00 PST 
Comment on attachment 220394 [details]
Patch

Rejecting attachment 220394 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
eC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/DOMAbstractView.o bindings/objc/DOMAbstractView.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/DOMAttr.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/DOMAttr.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(3 failures)

Full output: http://webkit-queues.appspot.com/results/5377557826371584
Comment 7 Mark Rowe (bdash) 2014-01-06 22:05:41 PST 
Committed r161406: <http://trac.webkit.org/changeset/161406>