Bug 126493 - Prepare the ScrollingTree for remote use
Summary: Prepare the ScrollingTree for remote use
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-04 13:00 PST by Simon Fraser (smfr)
Modified: 2014-01-04 13:44 PST (History)
11 users (show)

See Also:


Attachments
Patch (15.19 KB, patch)
2014-01-04 13:05 PST, Simon Fraser (smfr)
sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-01-04 13:00:45 PST
Prepare the ScrollingTree for remote use
Comment 1 Simon Fraser (smfr) 2014-01-04 13:05:17 PST
Created attachment 220379 [details]
Patch
Comment 2 Sam Weinig 2014-01-04 13:10:23 PST
Comment on attachment 220379 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220379&action=review

> Source/WebCore/page/scrolling/ScrollingStateFixedNode.cpp:76
> +        static_cast<GraphicsLayer*>(layer())->syncPosition(position);

Should we have some checked casts for this?

> Source/WebCore/page/scrolling/ScrollingStateScrollingNode.cpp:79
>      // The cloned tree references PlatformLayers, which are safe to send to the scrolling thread.
>      // FIXME: this Mac threaded-scrolling assumption doesn't belong here.

Does this comment still hold? You removed a similar one above.

> Source/WebCore/page/scrolling/ScrollingStateStickyNode.cpp:76
> +        static_cast<GraphicsLayer*>(layer())->syncPosition(position);

Checked cast?

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:201
> +void ScrollingStateTree::setRemovedNodes(const Vector<ScrollingNodeID>& nodes)
> +{
> +    m_nodesRemovedSinceLastCommit = nodes;
> +}

Does this do a copy? Can we make it a move?

> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:208
> +    StateNodeMap::const_iterator it = m_stateNodeMap.find(scrollLayerID);

auto?
Comment 3 EFL EWS Bot 2014-01-04 13:10:53 PST
Comment on attachment 220379 [details]
Patch

Attachment 220379 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5966973905141760
Comment 4 Simon Fraser (smfr) 2014-01-04 13:44:24 PST
http://trac.webkit.org/changeset/161315