Bug 126488 - Move ViewState to WebCore
Summary: Move ViewState to WebCore
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 525.x (Safari 3.1)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2014-01-04 01:16 PST by Gavin Barraclough
Modified: 2014-01-06 11:25 PST (History)
5 users (show)

See Also:

WIP patch for EWS (18.29 KB, patch)
2014-01-04 01:17 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
Fix (37.90 KB, patch)
2014-01-04 17:39 PST, Gavin Barraclough
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
style+GTK fix (37.94 KB, patch)
2014-01-04 18:41 PST, Gavin Barraclough
no flags Details | Formatted Diff | Diff
update (37.94 KB, patch)
2014-01-05 00:32 PST, Gavin Barraclough
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-01-04 01:16:53 PST
With hindsight the new way of doing this isn't in all ways simpler, and it won't make sense to move this to WebCore (where ViewState is going).
Not a direct revert to keep some of the clean up.
Comment 1 Gavin Barraclough 2014-01-04 01:17:39 PST
Created attachment 220370 [details]
WIP patch for EWS
Comment 2 Gavin Barraclough 2014-01-04 17:39:57 PST
Created attachment 220381 [details]
Comment 3 WebKit Commit Bot 2014-01-04 17:41:36 PST
Attachment 220381 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/ViewState.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/ViewState.h', u'Source/WebKit2/Shared/WebPageCreationParameters.cpp', u'Source/WebKit2/Shared/WebPageCreationParameters.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.h', u'Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm', u'Source/WebKit2/UIProcess/PageClient.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/Plugins/PluginView.h', u'Source/WebKit2/WebProcess/WebPage/DrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h', u'Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/WebProcess/WebPage/DrawingArea.h:33:  "WebCore/IntRect.h" already included at Source/WebKit2/WebProcess/WebPage/DrawingArea.h:32  [build/include] [4]
Total errors found: 1 in 18 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 EFL EWS Bot 2014-01-04 17:49:49 PST
Comment on attachment 220381 [details]

Attachment 220381 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/6207138275786752
Comment 5 Gavin Barraclough 2014-01-04 18:41:59 PST
Created attachment 220383 [details]
style+GTK fix
Comment 6 Gavin Barraclough 2014-01-05 00:32:05 PST
Created attachment 220389 [details]
Comment 7 Gavin Barraclough 2014-01-06 11:25:27 PST
Committed revision 161357.