Bug 126486 - CStack Branch: ARM64 add of stack pointer not valid as second source operand
Summary: CStack Branch: ARM64 add of stack pointer not valid as second source operand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-03 23:40 PST by Michael Saboff
Modified: 2014-01-04 10:28 PST (History)
0 users

See Also:

Attachments
Patch (1.48 KB, patch)
2014-01-03 23:43 PST, Michael Saboff 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-01-03 23:40:26 PST 
Due to architectural limitations, the stack pointer register cannot be used as the second source operand for various instructions.  Currently only the add instruction is used by the macro assembler with the stack pointer as the second source operand.  The ARM64 add macro assembler can swap the two source operands in this case.
Comment 1 Michael Saboff 2014-01-03 23:43:59 PST 
Created attachment 220368 [details]
Patch
Comment 2 Mark Lam 2014-01-04 07:05:27 PST 
Comment on attachment 220368 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-01-04 10:28:14 PST 
Committed r161313: <http://trac.webkit.org/changeset/161313>