Bug 126465 - [GTK] [CMake] Parallel builds still fail when building WebKit2 GObject API unit tests
Summary: [GTK] [CMake] Parallel builds still fail when building WebKit2 GObject API un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-03 15:05 PST by Martin Robinson
Modified: 2014-01-06 10:57 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2014-01-03 15:07 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Fix bug description (1.82 KB, patch)
2014-01-03 15:12 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-01-03 15:05:38 PST 
We need to make more changes imilar to http://trac.webkit.org/changeset/161145/trunk/Source/WebKit2/UIProcess/API/gtk/tests/CMakeLists.txt to ensure that parallel builds work properly.
Comment 1 Martin Robinson 2014-01-03 15:07:34 PST 
Created attachment 220343 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-03 15:10:26 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2014-01-03 15:12:20 PST 
Created attachment 220344 [details]
Fix bug description
Comment 4 Martin Robinson 2014-01-06 10:57:37 PST 
Comment on attachment 220344 [details]
Fix bug description

Clearing flags on attachment: 220344

Committed r161354: <http://trac.webkit.org/changeset/161354>
Comment 5 Martin Robinson 2014-01-06 10:57:40 PST 
All reviewed patches have been landed.  Closing bug.