Bug 126457 – [iOS] [WK2] TileController creates all tiles on first paint, making it slow and consuming lots of memory

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

Otherwise, we make all of the tiles upfront.

We can reuse the view exposed rect mechanism that already exists, we just have to:

1. Hook it up to WKView/WKContentView on iOS.
2. Plumb it through RemoteLayerTreeDrawingArea.
3. Make the WebPage(Proxy) bits available to iOS.

There is a good bit of cleanup of all of this stuff that should happen, but this at least gets us to a functional state.

[Radar WebKit Bug Importer]

<rdar://problem/15745931>

[Tim Horton]

Created attachment 220335 [details]
patch

[Tim Horton]

Created attachment 220336 [details]
fix the title for sam

[Tim Horton]

Comment on attachment 220336 [details]
fix the title for sam

View in context: https://bugs.webkit.org/attachment.cgi?id=220336&action=review

> Source/WebKit2/ChangeLog:24
> +        We can't use the existing WKContentView didScrollTo:, because it is
> +        expected to only fire when a scroll lands. Instead, add didLiveScrollTo:,
> +        which fires continually as scrolling progresses.

Naming proposal: rename didScrollTo: to didFinishScrollTo:, and use didScrollTo: instead of didLiveScrollTo:

[Simon Fraser (smfr)]

Comment on attachment 220336 [details]
fix the title for sam

View in context: https://bugs.webkit.org/attachment.cgi?id=220336&action=review

> Source/WebKit2/UIProcess/API/ios/WKContentView.h:68
> +- (void)didLiveScrollTo:(CGPoint)contentOffset;

Hmm, we don't really use the term "live scroll" anywhere else.

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:141
> +    _page->viewExposedRectChanged(FloatRect(_page->viewExposedRect().location(), FloatSize(size)), true);

No idea what true means.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4398
> +void WebPageProxy::viewExposedRectChanged(const FloatRect& exposedRect, bool clipsToExposedRect)

Please replace clipsToExposedRect with an enum

[Tim Horton]

http://trac.webkit.org/changeset/161296