Bug 126456 - Add lineageOfType renderer iterator and start using it.
Summary: Add lineageOfType renderer iterator and start using it.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-03 13:29 PST by Andreas Kling
Modified: 2014-01-07 11:34 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.22 KB, patch)
2014-01-03 14:04 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-01-03 13:29:06 PST 
We should have a lineageOfType iterator for renderers, just like we already do for elements.
Comment 1 Andreas Kling 2014-01-03 14:04:59 PST 
Created attachment 220337 [details]
Patch
Comment 2 Geoffrey Garen 2014-01-03 14:45:26 PST 
Comment on attachment 220337 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-01-03 15:15:52 PST 
Comment on attachment 220337 [details]
Patch

Clearing flags on attachment: 220337

Committed r161288: <http://trac.webkit.org/changeset/161288>
Comment 4 WebKit Commit Bot 2014-01-03 15:15:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2014-01-07 11:34:04 PST 
Comment on attachment 220337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220337&action=review

> Source/WebCore/rendering/RenderAncestorIterator.h:187
> +inline RenderAncestorIteratorAdapter<T> lineageOfType(RenderObject& first)

"lineageOfType" doesn't tell me that this is walking the ancestor chain (you can have a descendant lineage as well as an ancestor lineage). Can we rename it to ancestorLineageOfType()?