RESOLVED FIXED126456
Add lineageOfType renderer iterator and start using it. 
https://bugs.webkit.org/show_bug.cgi?id=126456
Summary Add lineageOfType renderer iterator and start using it.
Andreas Kling
Reported 2014-01-03 13:29:06 PST
We should have a lineageOfType iterator for renderers, just like we already do for elements.
Attachments
Patch (7.22 KB, patch)
2014-01-03 14:04 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-01-03 14:04:59 PST
Created attachment 220337 [details] Patch
Geoffrey Garen
Comment 2 2014-01-03 14:45:26 PST
Comment on attachment 220337 [details] Patch r=me
WebKit Commit Bot
Comment 3 2014-01-03 15:15:52 PST
Comment on attachment 220337 [details] Patch Clearing flags on attachment: 220337 Committed r161288: <http://trac.webkit.org/changeset/161288>
WebKit Commit Bot
Comment 4 2014-01-03 15:15:54 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5 2014-01-07 11:34:04 PST
Comment on attachment 220337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220337&action=review > Source/WebCore/rendering/RenderAncestorIterator.h:187 > +inline RenderAncestorIteratorAdapter<T> lineageOfType(RenderObject& first) "lineageOfType" doesn't tell me that this is walking the ancestor chain (you can have a descendant lineage as well as an ancestor lineage). Can we rename it to ancestorLineageOfType()?
Note You need to log in before you can comment on or make changes to this bug.