Bug 126454 - [super dealloc] missing in Source/JavaScriptCore/API/tests/testapi.mm, fails to build with -Werror,-Wobjc-missing-super-calls
Summary: [super dealloc] missing in Source/JavaScriptCore/API/tests/testapi.mm, fails ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-03 12:54 PST by David Farler
Modified: 2014-01-03 18:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2014-01-03 12:58 PST, David Farler 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2014-01-03 17:17 PST, David Farler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2014-01-03 12:54:01 PST 
Source/JavaScriptCore/API/tests/testapi.mm:172:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]

Source/JavaScriptCore/API/tests/testapi.mm:440:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
Comment 1 David Farler 2014-01-03 12:58:05 PST 
Created attachment 220331 [details]
Patch
Comment 2 Mark Rowe (bdash) 2014-01-03 13:10:43 PST 
Comment on attachment 220331 [details]
Patch

This'll break the 64-bit build.
Comment 3 Mark Rowe (bdash) 2014-01-03 13:12:01 PST 
The file is built with ARC enabled on all architectures that support it (e.g., everything but i386), and [super dealloc] will generate an error under ARC.
Comment 4 Geoffrey Garen 2014-01-03 14:09:57 PST 
Comment on attachment 220331 [details]
Patch

It looks like we've been using "#if !__has_feature(objc_arc)" to handle stuff like this.
Comment 5 David Farler 2014-01-03 14:21:26 PST 
Nice, that’s exactly what I was testing locally.
Comment 6 David Farler 2014-01-03 17:17:54 PST 
Created attachment 220357 [details]
Patch
Comment 7 Geoffrey Garen 2014-01-03 17:25:29 PST 
Comment on attachment 220357 [details]
Patch

r=me
Comment 8 David Farler 2014-01-03 17:45:44 PST 
Comment on attachment 220357 [details]
Patch

Thanks!
Comment 9 WebKit Commit Bot 2014-01-03 18:14:38 PST 
Comment on attachment 220357 [details]
Patch

Clearing flags on attachment: 220357

Committed r161304: <http://trac.webkit.org/changeset/161304>
Comment 10 WebKit Commit Bot 2014-01-03 18:14:40 PST 
All reviewed patches have been landed.  Closing bug.