RESOLVED FIXED126440
[MediaControls][iOS] Enable JavaScript Media Controls on iOS. 
https://bugs.webkit.org/show_bug.cgi?id=126440
Summary [MediaControls][iOS] Enable JavaScript Media Controls on iOS.
Jer Noble
Reported 2014-01-03 10:39:39 PST
[MediaControls][iOS] Enable JavaScript Media Controls on iOS.
Attachments
Patch (24.20 KB, patch)
2014-01-03 11:19 PST, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2014-01-03 11:19:28 PST
Created attachment 220321 [details] Patch
Eric Carlson
Comment 2 2014-01-03 12:06:27 PST
Comment on attachment 220321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review > Source/WebCore/DerivedSources.make:850 > +ifeq ($(WTF_PLATFORM_IOS),1) Nit: there should be a space after the comma. > Source/WebCore/DerivedSources.make:870 > +ifeq ($(WTF_PLATFORM_IOS),1) Ditto. > Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:185 > + /* rotateZ() forces the layer into compositing mode. > + Slider thumbs are small, so forcing a compositing layer is inexpensive, > + and it keeps the slider from having to repaint while sliding. */ Nit: good comment, but strange indentation.
Jer Noble
Comment 3 2014-01-03 12:47:03 PST
Committed r161280: <http://trac.webkit.org/changeset/161280>
Geoffrey Garen
Comment 4 2014-01-03 14:13:06 PST
Comment on attachment 220321 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:1205 > String RenderThemeIOS::mediaControlsScript() Can we refactor this to use JSScriptCreateReferencingImmortalASCIIText, or at least JSScriptCreateFromString?
Jer Noble
Comment 5 2014-01-03 14:38:59 PST
(In reply to comment #4) > (From update of attachment 220321 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review > > > Source/WebCore/rendering/RenderThemeIOS.mm:1205 > > String RenderThemeIOS::mediaControlsScript() > > Can we refactor this to use JSScriptCreateReferencingImmortalASCIIText, or at least JSScriptCreateFromString? Absolutely. We could do the same for the Mac version as well.
Note You need to log in before you can comment on or make changes to this bug.