Bug 126417 - VibrationPattern should allocate an single vector instance for single integer input
Summary: VibrationPattern should allocate an single vector instance for single integer...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
Depends on:
Reported: 2014-01-02 22:32 PST by Jinwoo Song
Modified: 2014-01-03 00:41 PST (History)
7 users (show)

See Also:

Patch (6.19 KB, patch)
2014-01-02 22:48 PST, Jinwoo Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-01-02 22:32:18 PST
When the Vibration pattern is set with a single integer, the VibrationPattern should set the vibration time with this value.
But the VibrationPattern(unsigned vector) was initialized with a single parameter, the vibration time, so the time was used to 
set the size of vector.
Comment 1 Jinwoo Song 2014-01-02 22:48:43 PST
Created attachment 220281 [details]
Comment 2 Gyuyoung Kim 2014-01-02 23:44:31 PST
CC'ing Kihong
Comment 3 Gyuyoung Kim 2014-01-03 00:04:05 PST
Comment on attachment 220281 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=220281&action=review


> Source/WebCore/Modules/vibration/NavigatorVibration.cpp:43
> +    return NavigatorVibration::vibrate(navigator, VibrationPattern(1, time));

Good catch ! We have missed this one so far.
Comment 4 WebKit Commit Bot 2014-01-03 00:41:19 PST
Comment on attachment 220281 [details]

Clearing flags on attachment: 220281

Committed r161257: <http://trac.webkit.org/changeset/161257>
Comment 5 WebKit Commit Bot 2014-01-03 00:41:22 PST
All reviewed patches have been landed.  Closing bug.