Bug 126409 - CStack LLInt 32-bit should build
Summary: CStack LLInt 32-bit should build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 116888
  Show dependency treegraph
 
Reported: 2014-01-02 15:10 PST by Filip Pizlo
Modified: 2014-01-02 15:50 PST (History)
8 users (show)

See Also:


Attachments
the patch (13.57 KB, patch)
2014-01-02 15:11 PST, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-01-02 15:10:15 PST
And the stuff we do to make it build should at least try to be correct
Comment 1 Filip Pizlo 2014-01-02 15:11:51 PST
Created attachment 220260 [details]
the patch
Comment 2 Filip Pizlo 2014-01-02 15:25:12 PST
Landed in the branch in http://trac.webkit.org/changeset/161234
Comment 3 Michael Saboff 2014-01-02 15:25:39 PST
Comment on attachment 220260 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220260&action=review

r=me, with comments.

> Source/JavaScriptCore/ChangeLog:8
> +        

Description of what you did...

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:165
>          const extraStackSpace = 16

This line can be removed.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:177
>          const extraStackSpace = 28

This line can be removed.
Comment 4 Filip Pizlo 2014-01-02 15:50:47 PST
Landed fixes to address Michael's comments in http://trac.webkit.org/changeset/161237