RESOLVED FIXED 126397
[GTK] Switch from WTF::Function to std::function in WebProcessTest 
https://bugs.webkit.org/show_bug.cgi?id=126397
Summary [GTK] Switch from WTF::Function to std::function in WebProcessTest
Zan Dobersek
Reported 2014-01-02 12:48:45 PST
[GTK] Switch from WTF::Function to std::function in WebProcessTest
Attachments
Patch (3.17 KB, patch)
2014-01-02 12:52 PST, Zan Dobersek 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-01-02 12:52:17 PST
Created attachment 220244 [details] Patch
WebKit Commit Bot
Comment 2 2014-01-02 12:53:54 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Anders Carlsson
Comment 3 2014-01-02 18:09:01 PST
Comment on attachment 220244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review > Source/WebKit2/ChangeLog:9 > + following the effor of using STL concepts where possible. Effort. (This is great btw, I'd really like to get rid of WTF::Function). We usually put a space between the return type and the left parenthesis for function types. > Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 > + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) Do you even need std::bind here?
Zan Dobersek
Comment 4 2014-01-02 23:24:27 PST
Comment on attachment 220244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review >> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37 >> + WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create)) > > Do you even need std::bind here? No, std::bind isn't needed.
Zan Dobersek
Comment 5 2014-01-02 23:36:54 PST
Committed r161253: <http://trac.webkit.org/changeset/161253>
Note You need to log in before you can comment on or make changes to this bug.