Bug 126397 - [GTK] Switch from WTF::Function to std::function in WebProcessTest
Summary: [GTK] Switch from WTF::Function to std::function in WebProcessTest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 12:48 PST by Zan Dobersek
Modified: 2014-01-02 23:36 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.17 KB, patch)
2014-01-02 12:52 PST, Zan Dobersek
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-01-02 12:48:45 PST
[GTK] Switch from WTF::Function to std::function in WebProcessTest
Comment 1 Zan Dobersek 2014-01-02 12:52:17 PST
Created attachment 220244 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-02 12:53:54 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Anders Carlsson 2014-01-02 18:09:01 PST
Comment on attachment 220244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review

> Source/WebKit2/ChangeLog:9
> +        following the effor of using STL concepts where possible.

Effort.

(This is great btw, I'd really like to get rid of WTF::Function). 

We usually put a space between the return type and the left parenthesis for function types.

> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37
> +    WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create))

Do you even need std::bind here?
Comment 4 Zan Dobersek 2014-01-02 23:24:27 PST
Comment on attachment 220244 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review

>> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37
>> +    WebProcessTest::add(String::fromUTF8(TestName), std::bind(&ClassName::create))
> 
> Do you even need std::bind here?

No, std::bind isn't needed.
Comment 5 Zan Dobersek 2014-01-02 23:36:54 PST
Committed r161253: <http://trac.webkit.org/changeset/161253>