Bug 126385 - Crash when trying to register a custom scheme before network process has been launched
Summary: Crash when trying to register a custom scheme before network process has been...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 08:42 PST by Carlos Garcia Campos
Modified: 2014-01-07 02:02 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.15 KB, patch)
2014-01-02 08:43 PST, Carlos Garcia Campos
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-01-02 08:42:38 PST
WebContext::registerSchemeForCustomProtocol() uses sendToNetworkingProcess() to send the message to the appropriate networking process. In the case of using web process, sendToNetworkingProcess() first checks if there's already a web process, doing nothing otherwise, but when using the network process it assumes there's already a network process. In both cases it's safe to do nothing, because the schemes will be passed as creation parameters to the process when launched.
Comment 1 Carlos Garcia Campos 2014-01-02 08:43:54 PST
Created attachment 220227 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-01-07 02:02:30 PST
Committed r161416: <http://trac.webkit.org/changeset/161416>