Bug 126379 – Video-seek-with-negative-playback is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Piotr Grad]

Already working on patch. Patch will be proposed soon.

[Piotr Grad]

Created attachment 220219 [details]
Patch

[Eric Carlson]

Comment on attachment 220219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220219&action=review

> Source/WebCore/ChangeLog:11
> +        Decision if playback rate for platform media player should be set is performed by checking m_playbackRate
> +        in HTMLMediaElement::endedPlayback(), so that m_playbackRate must be changed later.

I didn't understand this comment until I read through the sources several times. How about something like:

Test to see if m_player->setRate() should be called before updating m_playbackRate, because potentiallyPlaying() depends on endedPlayback(), which checks m_playbackRate.

[Piotr Grad]

Created attachment 220226 [details]
Patch

[EFL EWS Bot]

Comment on attachment 220226 [details]
Patch

Attachment 220226 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5706750963482624

[Piotr Grad]

(In reply to comment #4)
> (From update of attachment 220226 [details])
> Attachment 220226 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/5706750963482624

Source code is same as in first proposed patch, so don't know why it failed.

[Eric Carlson]

It looks like CoordinatedDrawingArea.cpp failed to compile:

[ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp.o
c++: internal compiler error: Killed (program cc1Failed to run "['Tools/Scripts/build-webkit', '--release', '--efl', '--update-efl', '--no-webkit1', '--makeargs="-j8"']" exit_code: 2

[Piotr Grad]

(In reply to comment #6)
> It looks like CoordinatedDrawingArea.cpp failed to compile:
> 
> [ 84%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp.o
> c++: internal compiler error: Killed (program cc1Failed to run "['Tools/Scripts/build-webkit', '--release', '--efl', '--update-efl', '--no-webkit1', '--makeargs="-j8"']" exit_code: 2

So this error is not related to patch proposed.

[WebKit Commit Bot]

Comment on attachment 220226 [details]
Patch

Clearing flags on attachment: 220226

Committed r161231: <http://trac.webkit.org/changeset/161231>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.