Bug 126378 – [Automake] Scripts for generated build targets do not necessarily produce their output

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[Automake] Touch idl_supplemental_dependencies at the end of its generation

[Zan Dobersek]

Created attachment 220215 [details]
Patch

[Zan Dobersek]

Comment on attachment 220215 [details]
Patch

There's more targets that need the same treatment.

[Alberto Garcia]

I'm trying to build webkitgtk 2.3.3 with make -j20 and it goes into
what looks like an infinite loop after a while. The -d output suggests
that it's a problem calculating the dependencies. make 3.82 seems to
fix that problem, so I updated and now I'm hitting this. I wonder if
they are related.

[Alberto Garcia]

Btw, instead of touching the file you can just make the perl script regenerate it every time, even when it's unchanged.

[Alberto Garcia]

(In reply to comment #3)
> I'm trying to build webkitgtk 2.3.3 with make -j20 and it goes into
> what looks like an infinite loop after a while. The -d output
> suggests that it's a problem calculating the dependencies. make 3.82
> seems to fix that problem, so I updated and now I'm hitting this. I
> wonder if they are related.

Nah, my problem with make seems to be a different one since I'm not
using the one from jhbuild.

[Zan Dobersek]

(In reply to comment #4)
> Btw, instead of touching the file you can just make the perl script regenerate it every time, even when it's unchanged.

True, but there are now at least three different scripts that don't necessarily generate their intended output. Changing their behavior might also not work well with builds of other ports.

I think just additionally touching the output after it's generated is the easiest fix for this.

[Zan Dobersek]

Created attachment 220233 [details]
Patch

[WebKit Commit Bot]

Attachment 220233 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.am', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

Created attachment 220236 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 220236 [details]
Patch

Ok, thanks.

[Zan Dobersek]

Committed r161497: <http://trac.webkit.org/changeset/161497>