Bug 126378 - [Automake] Scripts for generated build targets do not necessarily produce their output
Summary: [Automake] Scripts for generated build targets do not necessarily produce the...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-02 03:14 PST by Zan Dobersek
Modified: 2014-01-08 07:09 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.11 KB, patch)
2014-01-02 03:18 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (9.63 KB, patch)
2014-01-02 10:57 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (9.61 KB, patch)
2014-01-02 11:22 PST, Zan Dobersek
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-01-02 03:14:21 PST
[Automake] Touch idl_supplemental_dependencies at the end of its generation
Comment 1 Zan Dobersek 2014-01-02 03:18:56 PST
Created attachment 220215 [details]
Patch
Comment 2 Zan Dobersek 2014-01-02 03:47:03 PST
Comment on attachment 220215 [details]
Patch

There's more targets that need the same treatment.
Comment 3 Alberto Garcia 2014-01-02 04:55:40 PST
I'm trying to build webkitgtk 2.3.3 with make -j20 and it goes into
what looks like an infinite loop after a while. The -d output suggests
that it's a problem calculating the dependencies. make 3.82 seems to
fix that problem, so I updated and now I'm hitting this. I wonder if
they are related.
Comment 4 Alberto Garcia 2014-01-02 07:12:34 PST
Btw, instead of touching the file you can just make the perl script regenerate it every time, even when it's unchanged.
Comment 5 Alberto Garcia 2014-01-02 09:11:21 PST
(In reply to comment #3)
> I'm trying to build webkitgtk 2.3.3 with make -j20 and it goes into
> what looks like an infinite loop after a while. The -d output
> suggests that it's a problem calculating the dependencies. make 3.82
> seems to fix that problem, so I updated and now I'm hitting this. I
> wonder if they are related.

Nah, my problem with make seems to be a different one since I'm not
using the one from jhbuild.
Comment 6 Zan Dobersek 2014-01-02 10:43:33 PST
(In reply to comment #4)
> Btw, instead of touching the file you can just make the perl script regenerate it every time, even when it's unchanged.

True, but there are now at least three different scripts that don't necessarily generate their intended output. Changing their behavior might also not work well with builds of other ports.

I think just additionally touching the output after it's generated is the easiest fix for this.
Comment 7 Zan Dobersek 2014-01-02 10:57:23 PST
Created attachment 220233 [details]
Patch
Comment 8 WebKit Commit Bot 2014-01-02 11:00:11 PST
Attachment 220233 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/bindings/gobject/GNUmakefile.am', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/GNUmakefile.am', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Zan Dobersek 2014-01-02 11:22:11 PST
Created attachment 220236 [details]
Patch
Comment 10 Carlos Garcia Campos 2014-01-08 02:04:30 PST
Comment on attachment 220236 [details]
Patch

Ok, thanks.
Comment 11 Zan Dobersek 2014-01-08 07:09:09 PST
Committed r161497: <http://trac.webkit.org/changeset/161497>