Bug 126368 - Remove public attachRenderTree
Summary: Remove public attachRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 17:51 PST by Antti Koivisto
Modified: 2014-01-02 01:46 PST (History)
6 users (show)

See Also:

Attachments
patch (10.16 KB, patch)
2014-01-01 17:57 PST, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
another (10.16 KB, patch)
2014-01-01 23:52 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-01 17:51:38 PST 
Remove the remaining explicit render tree construction.
Comment 1 Antti Koivisto 2014-01-01 17:57:27 PST 
Created attachment 220198 [details]
patch
Comment 2 Andreas Kling 2014-01-01 18:03:25 PST 
Comment on attachment 220198 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220198&action=review

r=me

> Source/WebCore/html/shadow/InsertionPoint.h:100
> +inline InsertionPoint& toInsertionPoint(Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<InsertionPoint&>(node);
> +}
> +
> +inline const InsertionPoint& toInsertionPoint(const Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<const InsertionPoint&>(node);
> +}

Could we replace this gunk with NODE_TYPE_CASTS(InsertionPoint) instead?
Comment 3 EFL EWS Bot 2014-01-01 19:45:29 PST 
Comment on attachment 220198 [details]
patch

Attachment 220198 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/5956219843903488
Comment 4 Antti Koivisto 2014-01-01 23:52:53 PST 
Created attachment 220207 [details]
another
Comment 5 Antti Koivisto 2014-01-02 01:46:43 PST 
https://trac.webkit.org/r161205 (with fixes)