Bug 126366 - Remove reattachRenderTree
Summary: Remove reattachRenderTree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 15:12 PST by Antti Koivisto
Modified: 2022-07-30 13:27 PDT (History)
4 users (show)

See Also:

Attachments
patch (9.77 KB, patch)
2014-01-01 15:18 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-01 15:12:40 PST 
Remove the last remaining client.
Comment 1 Antti Koivisto 2014-01-01 15:18:10 PST 
Created attachment 220196 [details]
patch
Comment 2 Andreas Kling 2014-01-01 15:22:50 PST 
Comment on attachment 220196 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220196&action=review

r=me

> Source/WebCore/html/HTMLSelectElement.cpp:1264
> +            RenderMenuList* menuList = toRenderMenuList(renderer());

I'd make this a RenderMenuList&
Comment 3 Darin Adler 2014-01-01 21:36:51 PST 
Comment on attachment 220196 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220196&action=review

> Source/WebCore/html/HTMLSelectElement.cpp:1144
> +    ASSERT(renderer() && renderer()->isMenuList());

Any time we write an ASSERT that would have a "&&" we normally break it into two assertions. That way we can trivially tell which clause is failing if the assertion is hit.
Comment 4 Ahmad Saleem 2022-07-30 06:33:23 PDT 
I think this got landed in this commit:

https://github.com/WebKit/WebKit/commit/86fe1d37c2f5fde8ee8467e98d2d9e76251194c6

Can this be marked as "RESOLVED FIXED"? Thanks!
Comment 5 Ryosuke Niwa 2022-07-30 13:27:46 PDT 
Indeed, this patch got landed.