Bug 126363 - Remove elementChildren/elementDescendants shorthands
Summary: Remove elementChildren/elementDescendants shorthands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 13:25 PST by Antti Koivisto
Modified: 2014-01-02 00:46 PST (History)
1 user (show)

See Also:


Attachments
patch (19.96 KB, patch)
2014-01-01 13:30 PST, Antti Koivisto
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-01 13:25:50 PST
Just use childrenOfType<Element>/descendantsOfType<Element> instead.
Comment 1 Antti Koivisto 2014-01-01 13:30:42 PST
Created attachment 220192 [details]
patch
Comment 2 Antti Koivisto 2014-01-01 13:45:02 PST
https://trac.webkit.org/r161196
Comment 3 Darin Adler 2014-01-01 21:34:24 PST
Do childrenOfType and descendantsOfType really need “OfType” in their names?
Comment 4 Antti Koivisto 2014-01-02 00:37:57 PST
(In reply to comment #3)
> Do childrenOfType and descendantsOfType really need “OfType” in their names?

Probably not.
Comment 5 Antti Koivisto 2014-01-02 00:46:33 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Do childrenOfType and descendantsOfType really need “OfType” in their names?
> 
> Probably not.

With such generic names collisions with local variables and class members might get annoying. But maybe it is not a real problem.