RESOLVED FIXED 126363
Remove elementChildren/elementDescendants shorthands 
https://bugs.webkit.org/show_bug.cgi?id=126363
Summary Remove elementChildren/elementDescendants shorthands
Antti Koivisto
Reported 2014-01-01 13:25:50 PST
Just use childrenOfType<Element>/descendantsOfType<Element> instead.
Attachments
patch (19.96 KB, patch)
2014-01-01 13:30 PST, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-01-01 13:30:42 PST
Created attachment 220192 [details] patch
Antti Koivisto
Comment 2 2014-01-01 13:45:02 PST
https://trac.webkit.org/r161196
Darin Adler
Comment 3 2014-01-01 21:34:24 PST
Do childrenOfType and descendantsOfType really need “OfType” in their names?
Antti Koivisto
Comment 4 2014-01-02 00:37:57 PST
(In reply to comment #3) > Do childrenOfType and descendantsOfType really need “OfType” in their names? Probably not.
Antti Koivisto
Comment 5 2014-01-02 00:46:33 PST
(In reply to comment #4) > (In reply to comment #3) > > Do childrenOfType and descendantsOfType really need “OfType” in their names? > > Probably not. With such generic names collisions with local variables and class members might get annoying. But maybe it is not a real problem.
Note You need to log in before you can comment on or make changes to this bug.