Bug 126362 - Create a ThreadedScrollingTree subclass of ScrollingTree, and push all knowledge of the scrolling thread into it
Summary: Create a ThreadedScrollingTree subclass of ScrollingTree, and push all knowle...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 12:37 PST by Simon Fraser (smfr)
Modified: 2014-01-01 15:17 PST (History)
12 users (show)

See Also:


Attachments
Patch (34.79 KB, patch)
2014-01-01 12:43 PST, Simon Fraser (smfr)
sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-01-01 12:37:51 PST
Create a ThreadedScrollingTree subclass of ScrollingTree, and push all knowledge of the scrolling thread into it
Comment 1 Simon Fraser (smfr) 2014-01-01 12:43:16 PST
Created attachment 220190 [details]
Patch
Comment 2 Sam Weinig 2014-01-01 12:57:35 PST
Comment on attachment 220190 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220190&action=review

> Source/WebCore/page/scrolling/ThreadedScrollingTree.h:64
> +#if PLATFORM(MAC)

Can this be something more specific that PLATFORM(MAC), maybe ENABLE(WHEEL_EVENT_PHASE) or something?
Comment 3 Build Bot 2014-01-01 13:36:29 PST
Comment on attachment 220190 [details]
Patch

Attachment 220190 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5107353917587456
Comment 4 Simon Fraser (smfr) 2014-01-01 15:13:14 PST
(In reply to comment #2)
> (From update of attachment 220190 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220190&action=review
> 
> > Source/WebCore/page/scrolling/ThreadedScrollingTree.h:64
> > +#if PLATFORM(MAC)
> 
> Can this be something more specific that PLATFORM(MAC), maybe ENABLE(WHEEL_EVENT_PHASE) or something?

Yes, but not right now. Shame this wasn't done from the start :(
Comment 5 Simon Fraser (smfr) 2014-01-01 15:17:16 PST
https://trac.webkit.org/r161198