Bug 126361 - [CMake] The forwarding headers generated by WebKitMacros.m4 are incompatible with the headers generated by generate-forwarding-headers.pl
Summary: [CMake] The forwarding headers generated by WebKitMacros.m4 are incompatible ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 12:28 PST by Martin Robinson
Modified: 2014-01-03 08:59 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2014-01-01 12:31 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2014-01-01 12:28:46 PST 
The headers generated by the CMake macros in WebKitMacros.m4 use absolute paths, while generate-forwarding-headers.pl uses paths relative to the Source directory. This means that when the two paths generate headers into the same directory they will be overwritten unnecessarily if the CMake files change.
Comment 1 Martin Robinson 2014-01-01 12:31:24 PST 
Created attachment 220189 [details]
Patch
Comment 2 Philippe Normand 2014-01-03 00:21:22 PST 
Is the EWS green? I don't see the bubbles currently.
Comment 3 Philippe Normand 2014-01-03 00:23:23 PST 
Comment on attachment 220189 [details]
Patch

Ok yes it's green indeed :) the patch looks good as well!
Comment 4 Martin Robinson 2014-01-03 08:59:21 PST 
Comment on attachment 220189 [details]
Patch

Clearing flags on attachment: 220189

Committed r161263: <http://trac.webkit.org/changeset/161263>
Comment 5 Martin Robinson 2014-01-03 08:59:24 PST 
All reviewed patches have been landed.  Closing bug.