Bug 126359 – Do less synchronous render tree construction

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

Remove attachRenderTree calls from a bunch of places.

[Antti Koivisto]

Created attachment 220188 [details]
patch

[Anders Carlsson]

Comment on attachment 220188 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220188&action=review

> Source/WebCore/html/HTMLInputElement.cpp:742
> +        // This renderer and its children have quite different layouts and styles depending on
> +        // whether the speech button is visible or not. So we reset the whole thing and recreate
> +        // to get the right styles and layout.

Is this comment still accurate? Maybe tweak it to say something along the lines of "when style recalc happens the render tree will be completely reconstructed"?

> Source/WebCore/html/HTMLObjectElement.cpp:-389
> -    // FIXME: Style gets recalculated which is suboptimal.

Is this FIXME no longer relevant?

[Build Bot]

Comment on attachment 220188 [details]
patch

Attachment 220188 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5402065983504384

New failing tests:
fast/overflow/overflow-height-float-not-removed-crash3.html
fast/html/object-image-nested-fallback.html

[Build Bot]

Created attachment 220191 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Antti Koivisto]

https://trac.webkit.org/r161195