Bug 126359 - Do less synchronous render tree construction
Summary: Do less synchronous render tree construction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-01 10:00 PST by Antti Koivisto
Modified: 2014-01-01 13:17 PST (History)
4 users (show)

See Also:


Attachments
patch (11.47 KB, patch)
2014-01-01 11:16 PST, Antti Koivisto
andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (504.67 KB, application/zip)
2014-01-01 12:54 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-01-01 10:00:10 PST
Remove attachRenderTree calls from a bunch of places.
Comment 1 Antti Koivisto 2014-01-01 11:16:15 PST
Created attachment 220188 [details]
patch
Comment 2 Anders Carlsson 2014-01-01 11:41:44 PST
Comment on attachment 220188 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220188&action=review

> Source/WebCore/html/HTMLInputElement.cpp:742
> +        // This renderer and its children have quite different layouts and styles depending on
> +        // whether the speech button is visible or not. So we reset the whole thing and recreate
> +        // to get the right styles and layout.

Is this comment still accurate? Maybe tweak it to say something along the lines of "when style recalc happens the render tree will be completely reconstructed"?

> Source/WebCore/html/HTMLObjectElement.cpp:-389
> -    // FIXME: Style gets recalculated which is suboptimal.

Is this FIXME no longer relevant?
Comment 3 Build Bot 2014-01-01 12:54:35 PST
Comment on attachment 220188 [details]
patch

Attachment 220188 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5402065983504384

New failing tests:
fast/overflow/overflow-height-float-not-removed-crash3.html
fast/html/object-image-nested-fallback.html
Comment 4 Build Bot 2014-01-01 12:54:36 PST
Created attachment 220191 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 5 Antti Koivisto 2014-01-01 13:17:51 PST
https://trac.webkit.org/r161195