Bug 126355 – [CoordinatedGraphics] The changed scale of page should be applied to WebProcess directly when page is scaled.

• Status: NEW
• Component: WebKit EFL

[Hunseop Jeong]

Currently, don't send the changed scale of page to WebProcess directly when page is scaled.
Because scale of page in WebProcess isn't set in a moment, unnecessary calculation of tile is added.

[Hunseop Jeong]

Created attachment 220180 [details]
Patch

[Hunseop Jeong]

Created attachment 220181 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 220181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220181&action=review

Noam, could you take a look this ?

> Source/WebKit2/ChangeLog:8
> +        Because location of function for sending scale of page to WebProcess is wrong, scale of page in WebProcess isn't promptly set.

scale of page to WebProcess -> a scale of page to WebProcess ?

scale of page in WebProcess -> the scale of page in WebProcess ?

> Source/WebKit2/ChangeLog:9
> +        This patch moves function for sending scale of page to correct location.

I think this patch move a place of scalePage() invocation. This description seem a little unclear.

[Hunseop Jeong]

Created attachment 220805 [details]
Patch

[Noam Rosenthal]

Comment on attachment 220805 [details]
Patch

What is the implication of this? Is there a flicker? How is this tested?

[Gyuyoung Kim]

Comment on attachment 220805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220805&action=review

> Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:324
> +    m_webPageProxy->scalePage(m_pageScaleFactor, roundedIntPoint(m_contentsPosition));

Why do you call scalePage() in applyPositionAfterRenderingContents() instead of applyScaleAfterRenderingContents() ?

[Gyuyoung Kim]

Comment on attachment 220805 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220805&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] The changed scale of page should be applied to WebProcess directly when page is scaled.

[EFL] -> [CoordinatedGraphics]

[Hunseop Jeong]

When changed the scale of page, didn't apply the scale (In reply to comment #6)
> (From update of attachment 220805 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220805&action=review
> > Source/WebKit2/UIProcess/CoordinatedGraphics/PageViewportController.cpp:324
> > +    m_webPageProxy->scalePage(m_pageScaleFactor, roundedIntPoint(m_contentsPosition));
> Why do you call scalePage() in applyPositionAfterRenderingContents() instead of applyScaleAfterRenderingContents() ?

You are right, it was my fault.
I will move the scalePage() to applyScaleAfterRenderingContents().

[Hunseop Jeong]

Created attachment 225860 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #5)
> (From update of attachment 220805 [details])
> What is the implication of this? Is there a flicker? How is this tested?

As Noam said, you have to explain why we should move it. Any performance benefit ? I wonder it as well.

[Gyuyoung Kim]

Comment on attachment 225860 [details]
Patch

Clear r? because there was no reply against last question for a long time.

[Hunseop Jeong]

Sorry for the late reply.
I uploaded the patch for the benefit of scaling on the mobile phone.
But I don't know that this patch is still valid.