Bug 126353 - [Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member
Summary: [Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAtt...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 15:03 PST by Brendan Long
Modified: 2013-12-31 17:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2013-12-31 15:06 PST, Brendan Long 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-12-31 15:03:07 PST 
[Gtk] WebKitWebInspector has build warnings due to uninitialized didChangeAttachedWidth member
Comment 1 Brendan Long 2013-12-31 15:06:32 PST 
Created attachment 220172 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-31 15:09:15 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Brendan Long 2013-12-31 15:11:18 PST 
This is part of my personal quest to destroy all build warnings.

With changes like this, should I be landing them myself now?

Build output:

  CXX      Source/JavaScriptCore/disassembler/libjavascriptcoregtk_3_0_la-ARM64Disassembler.lo
In file included from ../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.cpp:27:0:
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendUnsignedImmediate64(uint64_t)':
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:175:42: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=]
         bufferPrintf("#0x%llx", immediate);
                                          ^
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h: In member function 'void JSC::ARM64Disassembler::A64DOpcode::appendPCRelativeOffset(uint32_t*, int32_t)':
../../Source/JavaScriptCore/disassembler/ARM64/A64DOpcode.h:180:74: error: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'uint64_t {aka long unsigned int}' [-Werror=format=]
         bufferPrintf("0x%llx", reinterpret_cast<uint64_t>(pc + immediate));
Comment 4 Brendan Long 2013-12-31 15:12:25 PST 
Er wrong build output. This is what it fixes:

../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp: In function 'WebKitWebInspector* webkitWebInspectorCreate(WebKit::WebInspectorProxy*)':
../../Source/WebKit2/UIProcess/API/gtk/WebKitWebInspector.cpp:331:5: error: missing initializer for member 'WKInspectorClientGtkV0::didChangeAttachedWidth' [-Werror=missing-field-initializers]
     };
Comment 5 WebKit Commit Bot 2013-12-31 17:04:32 PST 
Comment on attachment 220172 [details]
Patch

Clearing flags on attachment: 220172

Committed r161186: <http://trac.webkit.org/changeset/161186>
Comment 6 WebKit Commit Bot 2013-12-31 17:04:35 PST 
All reviewed patches have been landed.  Closing bug.