Bug 126351 - GtkXtBin uses deprecated gdk_threads_enter() and gdk_threads_leave()
Summary: GtkXtBin uses deprecated gdk_threads_enter() and gdk_threads_leave()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 14:03 PST by Brendan Long
Modified: 2015-01-28 11:15 PST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-12-31 14:03:18 PST 
As far as I can tell, these two functions were deprecated because everyone uses them incorrectly, and the new correct way of doing this is to do everything in a main-loop callback.

See: https://developer.gnome.org/gdk3/unstable/gdk3-Threads.html#GDK-THREADS-ENTER:CAPS

GtkXtBin doesn't seem to have an upstream as far as I can tell, but Firefox also uses it, so if we fix this, we might want to share the result with them.

Build output:

../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_prepare':
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:138:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations]
   gdk_threads_enter();
   ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:140:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations]
   gdk_threads_leave();
   ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_check':
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:148:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations]
   gdk_threads_enter();
   ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:153:5: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations]
     gdk_threads_leave();
     ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:157:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations]
   gdk_threads_leave();
   ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c: In function 'xt_event_dispatch':
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:171:3: warning: 'gdk_threads_enter' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:46) [-Wdeprecated-declarations]
   gdk_threads_enter();
   ^
../../Source/WebCore/plugins/gtk/gtk2xtbin.c:182:3: warning: 'gdk_threads_leave' is deprecated (declared at /usr/include/gtk-3.0/gdk/gdkthreads.h:48) [-Wdeprecated-declarations]
   gdk_threads_leave();
Comment 1 Brendan Long 2015-01-28 11:15:17 PST 
This file doesn't seem to exist anymore.