Bug 126350 - [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKit2 GObject API unit tests
Summary: [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKit2 GObject...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-31 13:48 PST by Martin Robinson
Modified: 2014-01-01 07:38 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2013-12-31 13:50 PST, Martin Robinson 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2013-12-31 13:48:35 PST 
The define is wrong, so the tests are failing.
Comment 1 Martin Robinson 2013-12-31 13:50:05 PST 
Created attachment 220170 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-31 13:50:56 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-01-01 02:55:35 PST 
Comment on attachment 220170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220170&action=review

> Source/WebKit2/ChangeLog:3
> +        [GTK] [CMake] Fix the WEBKIT_SRC_DIR define when building the WebKi2 GObject API unit tests

btw, please fix the typo in the changelog before landing
Comment 4 Martin Robinson 2014-01-01 07:38:07 PST 
Committed r161189: <http://trac.webkit.org/changeset/161189>